Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify store actions export #5364

Merged
merged 1 commit into from
Mar 21, 2024
Merged

refactor: simplify store actions export #5364

merged 1 commit into from
Mar 21, 2024

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Mar 21, 2024 •
edited
Loading

Done

  • refactor: simplify store actions export

Notes

  • This work has been automated using a python script and a set of regular expressions.
  • Increase in the number of lines is due to consistent usage of names which can result in longer line.
    Any instance of actions has been replaced with a model specific equivalent,
    e.g. actions.createWithMachineswith resourcePoolActions.createWithMachines

https://github.com/canonical/maas-ui/pull/5364/files#diff-a7e6b768a62b8a11a66c2fbb4a6458603bc9d954526f87eaec7e9fcb0ae4d981L76-L79

@webteam-app
Copy link

Demo starting at https://maas-ui-5364.demos.haus

@petermakowski petermakowski force-pushed the refactor-store-actions branch 7 times, most recently from e3470a5 to 1d9010a Compare March 21, 2024 10:05
@petermakowski petermakowski changed the title refactor: simplify store actions export WIP refactor: simplify store actions export Mar 21, 2024
@petermakowski petermakowski marked this pull request as ready for review March 21, 2024 13:54
@petermakowski petermakowski force-pushed the refactor-store-actions branch 2 times, most recently from 5cd2ef0 to d6b679e Compare March 21, 2024 15:02
@ndv99
Copy link
Contributor

ndv99 commented Mar 21, 2024

Couple of lint issues to fix:

Error: src/app/base/components/node/StorageTables/FilesystemsTable/DeleteFilesystem/DeleteFilesystem.test.tsx(5,10): error TS2614: Module '"@/app/store/machine"' has no exported member 'actions'. Did you mean to use 'import actions from "@/app/store/machine"' instead?
Error: src/app/base/components/node/StorageTables/FilesystemsTable/DeleteSpecialFilesystem/DeleteSpecialFilesystem.test.tsx(5,10): error TS2614: Module '"@/app/store/machine"' has no exported member 'actions'. Did you mean to use 'import actions from "@/app/store/machine"' instead?
Error: src/app/base/components/node/StorageTables/FilesystemsTable/UnmountFilesystem/UnmountFilesystem.test.tsx(5,10): error TS2614: Module '"@/app/store/machine"' has no exported member 'actions'. Did you mean to use 'import actions from "@/app/store/machine"' instead?

@petermakowski petermakowski force-pushed the refactor-store-actions branch from d6b679e to edd5974 Compare March 21, 2024 15:10
@petermakowski
Copy link
Contributor Author

Couple of lint issues to fix:

Looks like something got messed up during rebase. Should be fixed now.

@petermakowski petermakowski force-pushed the refactor-store-actions branch from edd5974 to bac2ddc Compare March 21, 2024 15:13
ndv99
ndv99 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another banger! LGTM

@ndv99
Copy link
Contributor

ndv99 commented Mar 21, 2024

@petermakowski merge conflict

@petermakowski petermakowski force-pushed the refactor-store-actions branch from bac2ddc to e846f35 Compare March 21, 2024 15:41
@petermakowski
Copy link
Contributor Author

@petermakowski merge conflict

Fixed!

@petermakowski petermakowski merged commit 41fd7c8 into canonical:main Mar 21, 2024
6 checks passed
@petermakowski petermakowski deleted the refactor-store-actions branch May 9, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

@Jay-Topher Jay-Topher Awaiting requested review from Jay-Topher

Assignees
No one assigned
Labels
Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @ndv99